Refactor AdminConsole vs. OptionalFeatureService#6828
Merged
labkey-adam merged 4 commits intodevelopfrom Jul 15, 2025
Merged
Conversation
Contributor
|
Manual testing notes
|
Contributor
Author
Thanks! And yeah, I provide no guarantees about or insight into the suitability of any particular experimental/optional feature 😄 |
labkey-jeckels
approved these changes
Jul 9, 2025
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Code changes look good. Not sure where the test coverage will live - if added to this PR it should get a separate review.
|
|
||
| // The maintained view map is now case-insensitive, so this is identical to the above method | ||
| @Deprecated // Call getPortalPart() instead | ||
| @Deprecated // Call getPortalPart() instead - TODO: DELETE, unused |
Contributor
There was a problem hiding this comment.
Can this be deleted now?
Contributor
Author
There was a problem hiding this comment.
I'll delete in a follow-on PR to reduce build breaks in others' pending PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
In the past, optional feature handling was arbitrarily split between
AdminConsole(feature flag registration & retrieval) andOptionalFeatureService(feature flag enabling/disability & listener handling). This PR moves all handling to the service for consistency and implements some other clean up.Changes
AdminConsole.OptionalFeatureFlagto a top-level classOptionalFeatureService/Impl.gitattributesAll tests use APIs to set/unset deprecated/experimental/optional feature flags. We'd like to add a simple test that exercises the UI pages.
Tasks 📍